-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add trimmomatic to tools/ #192
base: main
Are you sure you want to change the base?
Conversation
} | ||
|
||
command <<< | ||
cd /usr/local/share/trimmomatic-0.36-5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this is necessary? biocontainers should have added a trimmomatic
executable to the $PATH, as that's what they usually do. It should be unneeded to invoke the full path here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was trying to work out access to the executable, but without cd'ing to the exact directory I wasn't able to get it to work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's likely because it's being called with java
. There is a utility wrapper script at /usr/local/bin/trimmomatic
that provides the functionality and is on PATH
. So you should be able to swap java -jar trimmomatic.jar
with trimmomatic
and remove the directory change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @adthrasher! Hadn't noticed that distinction
No description provided.